ports/rp2: Include check for CYW43_GPIO in machine_pin_cyw43.c #15854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dacefd to
33844d7
Compare
Signed-off-by: Christopher Parrott <chris@pimoroni.com>
33844d7 to
6c03f92
Compare
|
Code size report: |
dpgeorge
approved these changes
Sep 19, 2024
|
Thanks, rebased and merged in ded8bbd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing some experiments with IO expander support for the Pimoroni Yukon, I discovered that the
#ifcheck inmachine_pin_cyw43.conly checks thatMICROPY_PY_NETWORK_CYW43andMICROPY_HW_PIN_EXT_COUNTare defined.This is a reasonable assumption for the Pico W, but causes conflicts if someone (such as myself) wants to attach an external IO expander to their Pico W and have its pins appear as
Pinobjects.This PR addresses this by adding the additional checks for
defined(CYW43_GPIO) && CYW43_GPIO == 1tomachine_pin_cyw43.cletting board builds include wireless but separately choose whether the external IO pins come from the cyw43 or not.The long term solution of course would be to allow for multiple external pin types, but that feels like a bigger discussion, and is more than I currently require anyway.