esp32: Provide a specific path to linker.lf. #16013
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing a simple name relies on the right paths being searched at the right time. However, external boards, such as demonstrated in https://github.com/micropython/micropython-example-boards will fail to find the linker.lf file, and fail to build without providing a more explicit path. (Note that micropython-example-boards currently uses v1.21 of micropython, which predates the introduction of the linker.lf dependency, so it still works, this issue was uncovered while updating that repository to micropython v1.23)
Tested with builds for esp32 and builds and run tests for esp32-s3 with esp-idf 5.0.4, 5.1.2 and 5.2.2
Trade-offs and Alternatives
There may be other ways altogether of doing this?