Skip to content

esp32: Allow disabling USB CDC. #16035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

esp32: Allow disabling USB CDC. #16035

merged 1 commit into from
Oct 22, 2024
+1 −1

Conversation

vshymanskyy
Copy link
Contributor

@vshymanskyy vshymanskyy commented Oct 17, 2024 •
edited
Loading

Summary

Some of my ESP32-S3 boards need to have CDC disabled. For details, see #14217

My board definition includes:

// Disable USB CDC as the same pins are used by I2C0
#define MICROPY_HW_USB_CDC                  (0)
#define MICROPY_HW_ENABLE_USBDEV            (0)

After #15108 got merged, my board stopped building.

Testing

The build works after the proposed fix

@vshymanskyy vshymanskyy changed the title esp32: allow disabling USB CDC. esp32: Allow disabling USB CDC. Oct 17, 2024
@vshymanskyy vshymanskyy mentioned this pull request Oct 17, 2024
Closed
2 tasks
dpgeorge
dpgeorge reviewed Oct 18, 2024
View reviewed changes
@dpgeorge dpgeorge added this to the release-1.24.0 milestone Oct 18, 2024
@vshymanskyy @dpgeorge
esp32/modmachine: Allow building with USB CDC disabled.
8fef67b 
Signed-off-by: Volodymyr Shymanskyy <vshymanskyi@gmail.com>
@dpgeorge dpgeorge merged commit 8fef67b into micropython:master Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
port-esp32
Projects
None yet
Milestone
release-1.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vshymanskyy @dpgeorge