extmod/nimble: Remove asserts of ediv_rand_present and adjust comments. #16120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DvdGiessen this follows pretty much your patch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #16120 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 164 164
Lines 21345 21345
=======================================
Hits 21041 21041
Misses 304 304 ☔ View full report in Codecov by Sentry. |
|
Code size report: |
projectgus
approved these changes
Nov 4, 2024
I also had the same thought 😄 |
Recent versions of NimBLE (since release 1.6.0) removed this variable; see apache/mynewt-nimble@7cc8c08. We never used it except in an assert, so remove those asserts to make the code compatible with newer NimBLE versions (eg for the esp32 port). Signed-off-by: Damien George <damien@micropython.org>
eae9072 to
d278ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent versions of NimBLE (since release 1.6.0) removed this variable; see apache/mynewt-nimble@7cc8c08.
We never used it except in an assert, so remove those asserts to make the code compatible with newer NimBLE versions (eg for the esp32 port).
Testing
Not tested on hardware, but I verified that the PYBD-SF6 firmware (which uses NimBLE) is binary equivalent before and after this commit (except for the change in git hash stored in the firmware).