msvc: Use different output directories depending on build type #1615
Conversation
| This defaults to, for example for Configuration = Debug and Platform = x64: | ||
|
|
||
| micropython [PyBaseDir] | ||
| ├── ... |
There was a problem hiding this comment.
Is it ok to have non-ASCII characters in this file? I know it's just a comment, and the xml encoding is specified as utf-8, but ...?
There was a problem hiding this comment.
Good question but I'm not aware of any problems. msbuild is quite picky about what you put in the files and it loads this one so it should be ok. I actually just copy-pasted the output from the tree command but if you want I can replace it with pure ascii characters
There was a problem hiding this comment.
If you don't mind, I'd rather pure ASCII, just in case one day someone wants to view the file in a simple text editor that doesn't support utf-8.
There was a problem hiding this comment.
Fixed (I'll do another PR for the failing windows build due to unrelated changes)
c3515d5 to
86f1dde
Compare
This allows multiple versions (e.g. Debug/Release, x86/x64) of micropython.exe to co-exist instead and also solves potential problems where msbuild does not completely rebuild the output and/or pdb files when switching between builds, which in turn can cause linker errors in dependent projects. By default exe/map/... files go in windows/build/$(Configuration)$(Platform) After each build micropython.exe is still copied from the above directory to the windows directory though, as that is consistent with the other ports and the test runner by default uses that location as well. Also rename env.props -> path.props which is a clearer name, and add ample documentation in the affected build files. (also see discussion in micropython#1538)
86f1dde to
fe628aa
Compare
|
Sorry, this patch somehow slipped from attention. |
|
(Merged now) |
|
Thanks! |
This allows multiple versions (e.g. Debug/Release, x86/x64) of micropython.exe
to co-exist instead and also solves potential problems where msbuild does not
completely rebuild the output and/or pdb files when switching between builds,
which in turn can cause linker errors in dependent projects.
By default exe/map/... files go in windows/build/$(Configuration)$(Platform)
After each build micropython.exe is still copied from the above directory to
the windows directory though, as that is consistent with the other ports and
the test runner by default uses that location as well.
Also rename env.props -> path.props which is a clearer name,
and add ample documentation in the affected build files.
(also see discussion in #1538)