ports/rp2/mphalport.h: Fix mp_hal_pin_xyz() for pin>=32 #16191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16190
Testing
Tested on a board with an RP2350B, now NeoPixels on pins >=32 work.
Trade-offs and Alternatives
This usesgpio_put()
, thoughgpio_set_mask64()
might also work. The latter didn't work right away for me, and I did not bother testing further sincegpio_put()
worked fine, so it's possible I just did something wrong withgpio_set_mask64()
.