esp32/modsocket: Fix getaddrinfo hints to set AI_CANONNAME. #16210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Ah, I hacked around this to test something on IDF V5.3 a while back, too!
But this is the correct fix :)
Because the `ai_canonname` field is subsequently used. ESP32_GENERIC_S3 (at least) crashes with IDF 5.2.3 without this set. Signed-off-by: Damien George <damien@micropython.org>
5502edb to
611d8f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because the
ai_canonnamefield is subsequently used.ESP32_GENERIC_S3 (at least) crashes with IDF 5.2.3 without this set.
See #15841, and prior attempt at a fix in #15999.
Testing
Tested with the network tests,
./run-tests.py -t a0 net_*/*.py.