Skip to content

ports/rp2/boards: Add SparkFun Thing Plus RP2350 #16234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

ports/rp2/boards: Add SparkFun Thing Plus RP2350 #16234

wants to merge 5 commits into from

Conversation

sfe-SparkFro
Copy link
Contributor

@sfe-SparkFro sfe-SparkFro commented Nov 13, 2024 •
edited
Loading

Summary

To add support for this board from us: https://www.sparkfun.com/products/25134

Depends on #16057

Also depends on #15620, but this can be merged before that if needed

Testing

Tested with above dependencies merged locally on an initial production board, and all seems well.

@sfe-SparkFro
ports/rp2/boards: Add SparkFun Thing Plus RP2350
563bc40 
Signed-off-by: Dryw Wade <dryw.wade@sparkfun.com>
@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@sfe-SparkFro
ports/rp2/boards/SPARKFUN_THINGPLUS_RP2350: Update mpconfigboard.h
38c6c67 
Better pin definitions

Signed-off-by: Dryw Wade <dryw.wade@sparkfun.com>
@sfe-SparkFro sfe-SparkFro mentioned this pull request Dec 3, 2024
Closed
@sfe-SparkFro
Copy link
Contributor Author

Also added image: micropython/micropython-media#76

@dpgeorge dpgeorge added port-rp2 board-definition New or updated board definition files. Combine with a port- label. labels Dec 19, 2024
@sfe-SparkFro
ports/rp2/boards: Change Thing Plus RP2350 flash to 14MiB
f37bbba 
Signed-off-by: Dryw Wade <dryw.wade@sparkfun.com>
@dpgeorge
Copy link
Member

This is blocked on #16057.

@sfe-SparkFro
Copy link
Contributor Author

@dpgeorge No longer depends on #16057! I realized this was using an old implementation, so updated to match the Pico 2 W implementation. Still have the soft dependency on #15620, but that doesn't need to prevent this from being merged.

@dpgeorge
Copy link
Member

Rebased, squashed and merged in 0a9cc90

@dpgeorge dpgeorge closed this Jan 15, 2025
@sfe-SparkFro sfe-SparkFro deleted the add_sparkfun_thingplus_rp2350 branch January 15, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees
No one assigned
Labels
board-definition New or updated board definition files. Combine with a port- label. port-rp2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfe-SparkFro @dpgeorge