Skip to content

py/mkrules.mk: Move comment about partial clones outside make rule. #16595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

py/mkrules.mk: Move comment about partial clones outside make rule. #16595

merged 1 commit into from
Jan 17, 2025

Conversation

dpgeorge
Copy link
Member

Summary

Otherwise the comment is printed each time the rule is run.

Follow up to fdd606d.

Testing

Prior to this commit, running make submodules would print the comment, eg:


$ make submodules
Use make V=1 or set BUILD_VERBOSE in your environment to increase build verbosity.
Updating submodules: lib/mbedtls lib/berkeley-db-1.xx lib/micropython-lib
Synchronizing submodule url for 'lib/berkeley-db-1.xx'
Synchronizing submodule url for 'lib/mbedtls'
Synchronizing submodule url for 'lib/micropython-lib'
# If available, do blobless partial clones of submodules to save time and space.
# A blobless partial clone lazily fetches data as needed, but has all the metadata available (tags, etc.).
# Fallback to standard submodule update if blobless isn't available (earlier than 2.36.0)

After this commit the output is:

$ make submodules
Use make V=1 or set BUILD_VERBOSE in your environment to increase build verbosity.
Updating submodules: lib/mbedtls lib/berkeley-db-1.xx lib/micropython-lib
Synchronizing submodule url for 'lib/berkeley-db-1.xx'
Synchronizing submodule url for 'lib/mbedtls'
Synchronizing submodule url for 'lib/micropython-lib'

@dpgeorge dpgeorge added the py-core Relates to py/ directory in source label Jan 16, 2025
@dpgeorge dpgeorge requested a review from andrewleech January 16, 2025 05:00
@dpgeorge dpgeorge added this to the release-1.25.0 milestone Jan 16, 2025
@dpgeorge dpgeorge mentioned this pull request Jan 16, 2025
Merged
@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (84e0aca) to head (6db2997).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16595   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         167      167           
  Lines       21596    21596           
=======================================
  Hits        21291    21291           
  Misses        305      305

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgeorge
py/mkrules.mk: Move comment about partial clones outside make rule.
6db2997 
Otherwise the comment is printed each time the rule is run.

Follow up to fdd606d.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the py-mkrules-move-comment-outside-rule branch from 42af5b8 to 6db2997 Compare January 17, 2025 05:59
@dpgeorge dpgeorge merged commit 6db2997 into micropython:master Jan 17, 2025
63 checks passed
@andrewleech
Copy link
Contributor

Thanks for fixing this, I've been away from computer so missed the review but I certainly support this fix!

@dpgeorge
Copy link
Member Author

I've been away from computer so missed the review but I certainly support this fix!

Ah, sorry, I was pretty quick merging this, should have waited for you.

@dpgeorge dpgeorge deleted the py-mkrules-move-comment-outside-rule branch January 17, 2025 12:51
@andrewleech
Copy link
Contributor

@dpgeorge no you were right not to wait, we'd already discussed this issue briefly on my original pr about it and you got pr approval from Gus! I was basically just apologizing for not giving my approval also her in time 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@projectgus projectgus projectgus approved these changes

@andrewleech andrewleech Awaiting requested review from andrewleech

Assignees
No one assigned
Labels
py-core Relates to py/ directory in source
Projects
None yet
Milestone
release-1.25.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgeorge @andrewleech @projectgus