ports/stm32: Make ETH DMA buffer attributes configurable. #16633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code size report: |
dpgeorge
reviewed
Jan 25, 2025
ports/stm32/mpconfigport.h
Outdated
| @@ -193,6 +193,10 @@ extern const struct _mp_obj_type_t network_lan_type; | |||
| #define MICROPY_HW_NIC_ETH | |||
| #endif | |||
|
|
|||
| #ifndef MICROPY_HW_ETH_DMA_ATTRIBUTE | |||
| #define MICROPY_HW_ETH_DMA_ATTRIBUTE __attribute__((aligned(16384))); | |||
| #endif | |||
There was a problem hiding this comment.
I think this would be better in mpconfigboard_common.h, near the bottom of that file.
Signed-off-by: Kwabena W. Agyeman <kwagyeman@live.com>
6bd6729 to
84f883d
Compare
dpgeorge
approved these changes
Feb 4, 2025
|
Rebased and merged in 112f657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the attributes for the eth_dma buffer to be overridden by a port.
OpenMV's firmware for the Arduino Portenta stores .data in the DTCM which is inaccessible by the ethernet controller. By overriding the buffer's attributes with alignment and section specifications, we can place the ethernet buffer in the right SRAM location.