Skip to content

all: Run pre-commit tests in GitHub Actions. #16778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

all: Run pre-commit tests in GitHub Actions. #16778

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 18, 2025 •
edited
Loading

Summary

Consolidate files

  • .github/workflows/code_formatting.yml
  • .github/workflows/codespell.yml
  • .github/workflows/ruff.yml

into a single GitHub Action that uses pre-commit/action to run the same pre-commit hooks that contributors run on their local machines. This simplifies the versions and configurations of these tools.

name: pre-commit
jobs:
  hook:
    strategy:
        fail-fast: false
        matrix:
-         hook: [codeformat, codespell, ruff, ruff-format]
+         hook: [ruff]

Testing

GitHub Actions runs.

@cclauss cclauss changed the title all: Run pre-commit test in GitHub Actions all: Run pre-commit tests in GitHub Actions. Feb 18, 2025
@cclauss cclauss marked this pull request as draft February 18, 2025 12:56
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (3f0dd13) to head (e3cac10).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #16778   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         169      169           
  Lines       21822    21822           
=======================================
  Hits        21502    21502           
  Misses        320      320

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@cclauss cclauss force-pushed the pre-commit_action branch 3 times, most recently from 4ea0538 to eb39500 Compare February 25, 2025 09:07
@cclauss
all: Run pre-commit tests in GitHub Actions.
e3cac10 
Signed-off-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss closed this Feb 25, 2025
@cclauss cclauss deleted the pre-commit_action branch February 25, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cclauss