Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@dpgeorge I updated this to remove the old cywbt.c and switch to the new backend. I believe it was only used by MIMXRT and STM32, and I think we should remove it since it's causing some confusion. At one point, I had two firmware images each linking to a different backend. I tested both port, WiFi (HTTP/SSL) and Bluetooth (aioble blinky), and both seem to work fine.

I'm not sure why SF2 is overflowing, maybe it never used the CYWBT firmware? It works without it btw. In this case we'll probably need a custom config for boards.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (5eee5a6) to head (23c7f26).

@@           Coverage Diff           @@
##           master   #16848   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         169      169           
  Lines       21890    21890           
=======================================
  Hits        21571    21571           
  Misses        319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks, this is a good change. But it's is a bit too risky before a release, and will need to wait until after 1.25.0.

Thanks, this is a good change. But it's is a bit too risky before a release, and will need to wait until after 1.25.0.

I could rebase on #17050 and wait.

I'm not sure about mimxrt, but stm32 needs the following additional defines to make the new BT driver behave like the current one:

#define CYW43_HAL_UART_READCHAR_BLOCKING_WAIT __WFI()

#define CYW43_PIN_RFSW_SELECT           pyb_pin_WL_GPIO_1

#ifdef MICROPY_HW_BLE_UART_BAUDRATE_SECONDARY
#define CYW43_BT_UART_BAUDRATE_ACTIVE_USE MICROPY_HW_BLE_UART_BAUDRATE_SECONDARY
#endif
#ifdef MICROPY_HW_BLE_UART_BAUDRATE_DOWNLOAD_FIRMWARE
#define CYW43_BT_UART_BAUDRATE_DOWNLOAD_FIRMWARE MICROPY_HW_BLE_UART_BAUDRATE_DOWNLOAD_FIRMWARE
#endif

And also needs:

--- a/ports/stm32/boards/PYBD_SF2/f722_qspi.ld
+++ b/ports/stm32/boards/PYBD_SF2/f722_qspi.ld
@@ -49,7 +49,7 @@ SECTIONS
         *lib/mbedtls/*(.text* .rodata*)
         *lib/mynewt-nimble/*(.text* .rodata*)
         *lib/cyw43-driver/*(.rodata.w4343*_combined)
-        *drivers/cyw43/*(.rodata.cyw43_btfw_*)
+        *lib/cyw43-driver/*(.rodata.cyw43_btfw_*)
         . = ALIGN(4);
     } >FLASH_EXT
 }

I'm not sure about mimxrt, but stm32 needs the following additional defines to make the new BT driver behave like the current one:

I've added those to both stm32 and mimxrt. In Alif port, they're defined in board config files.