ports/esp32: Updated network_ppp.c to match current documentation #17008
+109
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f37067e to
e6843e7
Compare
e6843e7 to
c25e606
Compare
This commit updates the network.PPP module of the ESP32 port to match the current documentation. The the status() method should behave like the "common" LwIP implementation and the poll() method will raise an RuntimeError indicating that this is not really supported on this port. Signed-off-by: Thomas Kiss <thomas.kiss@lemonbeat.com>
c25e606 to
e70aa07
Compare
This was referenced Apr 5, 2025
|
I worked on similar changes previous year and finally submitted them as a PR last week, see #17138. That fixes a few crashes I was having, and as a side-effect also does address the your linked issue about the documentation not matching. Linking it here since you might find it interesting. Note these two PR's conflict. In the other PR I replaced parts of the ESP32 version with the extmod version. So for example it uses IRQ/poll() system from the extmod version for reading data from the UART and completely removes the task previously used by the ESP32 version. Whereas this PR one adds additional enhancements to the task management logic, and adds explicit warnings about the poll() method being unsupported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR updates the
network.PPPmodule of theESP32port to match the current documentation. Thestatus()method should behave like the common LwIP implementation and thepoll()method will raise an RuntimeError indicating that this is not really supported on this port. Also did some minor resorting to match the common LwIP implementation.This would solve #16998
Testing
Tested on
ESP32_GENERICandESP32_GENERIC_S3boards withSIMCOM800LandSIMCOM7080Gmodules. At least withESP32_GENERICthePPPconnection is connected at least18hours.