Skip to content

rp2/rp2_dma: Fix default value used in pack_ctrl on RP2350. #17201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

rp2/rp2_dma: Fix default value used in pack_ctrl on RP2350. #17201

merged 1 commit into from
May 9, 2025

Conversation

dpgeorge
Copy link
Member

Summary

The bit position of CHAIN_TO is not the same as on RP2040.

Testing

This was picked up by the tests/ports/rp2/rp2_dma.py test running on a RPI_PICO2 board.

(That test still doesn't pass, because of other reasons, to be fixed separately.)

@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@dpgeorge dpgeorge mentioned this pull request Apr 28, 2025
Merged
@dpgeorge
Copy link
Member Author

See improved test in #17202. This PR is needed for that test to pass fully.

@dpgeorge
rp2/rp2_dma: Fix default value used in pack_ctrl on RP2350.
9c8c219 
The bit position of CHAIN_TO is not the same as on RP2040.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the rp2-dma-fix-default-ctrl branch from 4977c23 to 9c8c219 Compare May 9, 2025 02:05
@dpgeorge dpgeorge merged commit 9c8c219 into micropython:master May 9, 2025
8 checks passed
@dpgeorge dpgeorge deleted the rp2-dma-fix-default-ctrl branch May 9, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-rp2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgeorge