nrf: Use common implementation of machine disable/enable IRQ. #17213
Conversation
Yes. I don't think there's any way around that? |
Yeah probably not, although there is a way to debug / step through application code on these chips without interrupting the stuff device called "monitor mode debugging". I bring this up because it presumably uses some form of interrupt masking which might work here to effectively mask out "application" interrupts without interrupting the soft device. |
|
Regardless, the changes look good, consolidating functionality and signatures to match other ports is a worthy direction to follow certainly. |
This is a breaking change due to the signature change of `enable_irq()`.
Previously the signature was:
machine.enable_irq()
Now the signature matches other ports, and the docs, and is:
machine.enable_irq(state)
Where `state` is the return value from `machine.disable_irq()`.
Signed-off-by: Damien George <damien@micropython.org>
9ac710a to
a1ee42c
Compare
Summary
This is a breaking change due to the signature change of
enable_irq(). Previously the signature was:Now the signature matches other ports, and the docs, and is:
Where
stateis the return value frommachine.disable_irq().Testing
Tested on ARDUINO_NANO_33_BLE_SENSE. That board now passes the
tests/extmod/machine_disable_irq.pytest.