nrf/mpconfigport: Enable IO.IOBase as a core feature. #17214
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IOBase is quite an important building block of other parts of the system, such as `mpremote mount` and running .mpy and native tests. It's also used by `asyncio` which is enabled by default on all boards. This feature costs +244 bytes of firmware size, which is worth the cost for the extra features it enables. Signed-off-by: Damien George <damien@micropython.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IOBase is quite an important building block of other parts of the system, such as
mpremote mountand running .mpy and native tests. It's also used byasynciowhich is enabled by default on all boards.This feature costs +244 bytes of firmware size, which is worth the cost for the extra features it enables.
Testing
Tested on PCA10028 and PCA10040, they can now run more tests.