ports/zephyr: Add mp_hal_stdio_poll(). #17606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to make input() work. Signed-off-by: Ned Konz <ned@metamagix.tech>
5bff98e to
780b69a
Compare
|
Thanks for the contribution. I actually implemented this already as part of PR #17552. Maybe you can test that PR with your board/configuration? |
|
Closing, fixed by #17552. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
mp_hal_stdio_poll()to the Zephyr port.This is required to make input() work.
Summary
I'm making a Zephyr MicroPython port for the XIAO BLE NRF52840 SENSE board, and discovered that
upysh'snewfilecommand required having
input()working. Getting this working required addingmp_hal_stdio_poll()to the port.Testing
I tested this on my XIAO BLE NRF52840 SENSE board, and was able to use
newfileand the builtininput()successfully.