Skip to content

rp2: on RP2350 configure jmp pins as input if they are in isolation mode #17781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

rp2: on RP2350 configure jmp pins as input if they are in isolation mode #17781

merged 2 commits into from
Aug 1, 2025

Conversation

dpgeorge
Copy link
Member

Summary

On RP2350, enable PIO jmp pins as input if they haven't already been configured. This allows them to work as input pins to the PIO. Otherwise the pin remains in isolation mode from reset and doesn't work as expected, in particular code that works on RP2040 does not work on RP2350.

Resolves issue #17047.

Testing

Tested with the code in #17047. Without the fix here the test fails (as described there). With the fix, it passes.

Trade-offs and Alternatives

The alternative would be to just document this. But I think a little bit of code to help things work "out of the box" makes it easier for users.

@dpgeorge dpgeorge mentioned this pull request Jul 29, 2025
Closed
@dpgeorge dpgeorge changed the title Rp2 pio jmp pin init as input rp2: on RP2350 configure jmp pins as input if they are in isolation mode Jul 29, 2025
@dpgeorge dpgeorge added this to the release-1.26.0 milestone Jul 29, 2025
@github-actions GitHub Actions
Copy link

Code size report:

   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@projectgus projectgus linked an issue Aug 1, 2025 that may be closed by this pull request
RP2350: PIO scripts fail, despite running on RP2040 #17047
Closed
dpgeorge added 2 commits August 1, 2025 15:10
@dpgeorge
rp2/rp2_pio: Configure jmp_pin for PIO use if it's isolation is set.
41987c6 
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
docs/library/rp2.StateMachine: Add a note about PIO in and jmp pins.
a9a606b 
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the rp2-pio-jmp-pin-init-as-input branch from 4882312 to a9a606b Compare August 1, 2025 05:11
@dpgeorge dpgeorge merged commit a9a606b into micropython:master Aug 1, 2025
9 checks passed
@dpgeorge dpgeorge deleted the rp2-pio-jmp-pin-init-as-input branch August 1, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@projectgus projectgus projectgus approved these changes

Assignees
No one assigned
Labels
port-rp2
Projects
None yet
Milestone
release-1.26.0
Development

Successfully merging this pull request may close these issues.

RP2350: PIO scripts fail, despite running on RP2040
2 participants
@dpgeorge @projectgus