Memory leaks in lexer/compiler #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
added a commit
that referenced
this pull request
Jan 23, 2014
Memory leaks in lexer/compiler
|
Also need to free the emitters allocated during compliation (but not their generated code). |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 31, 2017
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 31, 2017
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 31, 2017
Fixes micropython#172. Related to micropython#214.
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Sep 5, 2017
Fixes micropython#172. Related to micropython#214.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to study memory management in uPy... Fix in lexer is definitely ok, please confirm that scopes are also not needed once bytecode was generated. Tests pass of course.