docs/esp8266/tutorial/neopixel.rst: Updated docs to reflect api changes. #3336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfalcon
suggested changes
Oct 2, 2017
There was a problem hiding this comment.
Please follow commit message conventions in https://github.com/micropython/micropython/blob/master/CODECONVENTIONS.md . Please wrap the lines you add to the same length as the surrounding lines.
dpgeorge
reviewed
Oct 3, 2017
docs/esp8266/tutorial/neopixel.rst
Outdated
|
|
||
| >>> import machine, neopixel | ||
| >>> np = neopixel.NeoPixel(machine.Pin(4), 8, bpp=4) | ||
|
|
There was a problem hiding this comment.
You might want to mention that when the NeoPixel object is in 4-bpp mode then all the colour tuples (eg in the demos below) need to be 4-tuples, as opposed to 3-tuples.
There was a problem hiding this comment.
I've added an example as well and reordered the sections. If it doesn't make sense I'm open to further adjustments.
Added example of using 4-tuples and did some slight reordering.
|
Thanks for updating. Merged in 9e0cdb2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #2536 added a bpp parameter for selecting the number of LEDs per Pixel.