Micropython NXP LPC basic port #3354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First board introduced is EDU CIAA LPC4337 (educational board), using LPCOpen library for LPC18xx/43xx v3.01 as external module. This first commit should introduce some infrastructure for other boards to be easily supported. For now, let's just enable a very simple REPL. Signed-off-by: Ernesto Gigliotti <ernestogigliotti@gmail.com> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Signed-off-by: Martin Ribelotta <martinribelotta@gmail.com>
|
Hey @martinribelotta! Thanks for the effort. It looks much nicer now. @dpgeorge what do you think? |
| Chip_ENET_RMIIEnable(LPC_ETHERNET); | ||
| } | ||
|
|
||
| void Board_I2C_Init(I2C_ID_T id) |
There was a problem hiding this comment.
@martinribelotta Are these Board_XYZ_Init functions needed for a minimum UART REPL? If not, I'd say let's get rid of all the clutter. Once we have consensus on a minimal REPL it will be easier to add support hardware.
There was a problem hiding this comment.
+1 The Board_* is bad idea. My direction is to provide a CSV description of pins and labels on this board. Maybe this PR need more cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third version of LPC NXP support. Previos works are #3333 and #1732.
In this port LPCOpen is added as submodule dependency.
I'm not sure how to avoid checkout of several non-related and excluding modules like stm32lib and / or lpc43xxlib. Ideas are welcome.
This port is centered on LPC processors (LPC43xx, LPC541xx, LPC546xx) but is interesting to add others CPU from NXP like iMX-RT with @RockySong