Skip to content

backport of MrSurly/micropython-esp32@dev-deepsleep #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mactijn
Copy link

@mactijn mactijn commented Dec 30, 2017

This is a direct backport (?) of micropython/micropython-esp32#85 by @MrSurly

A quick test reveals it still works as intended, but no extensive testing has been done.

@MrSurly
Copy link
Contributor

MrSurly commented Dec 30, 2017

@dpgeorge @nickzoic

My understanding is that the existing PRs for the micropython-esp32 repo are still considered active?

If not, I can move them over.

@mactijn
Copy link
Author

mactijn commented Dec 30, 2017

I wasn't aware of that, my apologies if I've breached protocol or something.

This patch and the WPS one are stuff I needed, so I backported them. Not wanting to waste the effort I put into it, I pushed these PRs.

@MrSurly
Copy link
Contributor

MrSurly commented Dec 30, 2017

I wasn't aware of that, my apologies if I've breached protocol or something.

Not at all! I'm glad someone is using it. Just don't want duplicated effort.

@mactijn
Copy link
Author

mactijn commented Dec 31, 2017

I'm closing this PR again, as @MrSurly is continuing this in #3531

@mactijn mactijn closed this Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants