Implement __aeabi_f2d and __aeabi_d2f #356
Conversation
|
I have seen the same error you mentioned in note 2, for me the line of code that gets marked is for the log2f function. Build proceeds normally with that one line commented out. I had no idea what to make of that error. |
|
because after the prototype in math.h it's redefined as logf |
|
Thanks, I see it now. Are the prototypes in math.h also the reason for the problem I noted in issue #353 ? Just curious, trying to follow along with the work being done by people who actually know what they are doing ;) |
|
probably has something to do with the math header, but it is also related because double to float and float to double conversion was needed for printf to work |
No, there was a mistake in the code, that isfinite etc don't have --f versions (eg isfinitef does not exist for single prec, but sinf does). |
Implement __aeabi_f2d and __aeabi_d2f
If a soft reset happens while the gamepad module is scanning for button presses, there is a moment when the pins get de-initialized, but the gamepad module is still trying to read them, which ends in a crash. We can avoid it by disabling scanning on reset.
Note1: those are using the correct calling convention, they will read the argument from r0(+r1) because (all?) _aeabi functions should use softfp.
Note2: math.h breaks build (is it needed?):
Note3: I'm not sure if I'm supposed to handle overflows or special values, hopefully someone who knows better would improve this.