py/objstr.c: Implement str.rfind() and add tests for it, refactor find_subbytes(). #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
added a commit
that referenced
this pull request
Mar 25, 2014
py/objstr.c: Implement str.rfind() and add tests for it, refactor find_subbytes().
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Nov 7, 2017
…buffer of at least 1. (micropython#370) Fixes micropython#358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also got rid of "TODO use a non-exception-throwing mp_get_index" in str_count() and str_find() because they both now use mp_get_index()'s is_slice boolean, so they will no longer be throwing IndexErrors. They can still throw TypeErrors but that's intended.