nrf: Compile files in $(SRC_MOD) like all other ports. #3954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this was copied from stm32/Makefile, which does the same thing (adds SRC_MOD to SRC_QSTR). But note that in py/py.mk SRC_MOD is already added to SRC_QSTR, so it doesn't need to be added a second time. |
|
Ah, you're probably right. I don't know where it came from originally. I've looked a bit at the other ports, and most include |
Also, remove the unused $(SRC_LIB).
|
Merged in 8df342d |
jepler
referenced
this pull request
in jepler/circuitpython
Oct 24, 2020
In particular, this closes adafruit#3954.
jepler
referenced
this pull request
in jepler/circuitpython
Oct 24, 2020
In particular, this closes adafruit#3954.
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Jan 21, 2021
ESP32-S2: added sys.platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3871 (comment) for details.
CC @glennrub