Skip to content

nrf/uart: Fix UART.writechar() to write just 1 byte. #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

nrf/uart: Fix UART.writechar() to write just 1 byte. #4014

wants to merge 1 commit into from

Conversation

aykevl
Copy link
Contributor

@aykevl aykevl commented Aug 2, 2018

Found this issue while testing the UART. UART.writechar() now actually works.

@aykevl aykevl requested a review from glennrub August 2, 2018 19:47
glennrub
glennrub approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@glennrub glennrub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally never seen this as my UART has most of the time been occupied with UART REPL. LGTM.

@aykevl
Copy link
Contributor Author

aykevl commented Aug 2, 2018

Merged in e755bd4.

@aykevl aykevl closed this Aug 2, 2018
@aykevl aykevl deleted the nrf-uart-writechar branch August 2, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennrub glennrub glennrub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aykevl @glennrub