unix: moduselect: poll.mofify: Raise OSError(ENOENT) if object is not in poller #4197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 28, 2018 22:45
… in poller Previously, the function silently succeeded. The new behavior is consistent with both baremetal uselect implementation and CPython3.
This test doesn't check the actual I/O behavior, just "static" invariants like behavior on duplicate calls or calls when I/O object is not registered with poller.
E.g., register() can be called again for the same object, while modify() will raise exception if object was not register()ed before.
|
This addresses the obvious case of #1550 (comment), together with a test and doc updates. |
|
Thanks, looks good. Indeed the new test passes on existing bare-metal targets. Merged in d251f26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the function silently succeeded. The new behavior is consistent
with both baremetal uselect implementation and CPython3.