py: Put default namespace into module __main__. #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's how CPython has it, in particular, "import __main__" should work.
|
Ok, this is pretty clean change, so merging it - on critical path to doing test discovery in unittest module. |
|
What's funny here is that rge-sm was broken for me again in master. This patch fixes it. We apparently have some heap trashing, need to run thru valgrind. |
|
|
6582a41 fails (proof that it's not my prev commits either) is somebody will want to have a look. |
|
@dhylands: It fails in str.format() call if you care ;-) |
|
Yes, this is a clean change. |
|
rge-sm.py passes for me on 32- and 64-bit Arch Linux machines. |
|
Then it's random shooting pointer, like I said :-( |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Dec 5, 2017
micropython#427) Update info about erasing CIRCUITPY to include flash erasers for non-Express boards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's how CPython has it, in particular, "import main" should work.