unix/modos: Rename unlink() to remove() to be consistent with other ports. #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it makes sense to rename it to the more friendly name. But please can you update the io/open_append.py and io/open_plus.py tests to use rename instead of unlink so they still run on the unix port. |
added 2 commits
November 26, 2018 08:53
…orts. We standardized to provide uos.remove(), as more obvious and user-friendly name. That's what written in the docs. The Unix port implementation predates this convention, so update it now.
After Unix port switches from one to another, to be consistent with baremetal ports.
Updated. |
kamtom480
pushed a commit
to kamtom480/micropython
that referenced
this pull request
Mar 3, 2021
raspberrypi: allow directly specifying the original boot .S file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We standardized to provide uos.remove(), as more obvious and user-friendly
name. That's what written in the docs. The Unix port implementation predates
this convention, so update it now.