ports/samd: Add Adafruit Feather M0 Express, and Mini SAM M4 #4994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename board.mk to mpconfigboard.mk to match other ports (e.g. stm32).
Similar to a previous comment, probably best to just put this in the global .gitignore.
I originally made it board.mk to keep it short and simple, and maybe even stm32 could change to use that as well. But I guess there's no real reason for the change (to board.mk) and mpconfigboard.mk consistently pairs with mpconfigboard.h. Anyway, looks good! If you agree with the gitignore change I can do that myself first, then merge this without that specific commit. |
|
Thanks, I've made the global .gitignore change in #4991 (and force pushed), but yes feel free to adjust as necessary. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Jul 15, 2021
…logio-deinit added pin object to analogout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: