ports/nrf: Add Particle Xenon board (NRF52840) #5041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e correct index. It was previously not taking into account that the list of pins was sparse, so using the wrong index. So the boards/X/pins.csv was generating the wrong data for machine.Pin.board. Also rename the variables to make it more clear what the list contains (only board pins).
Also rename `flash` target to `deploy` to match other ports (but provide `flash` as an alias for backwards compatibility).
f2b73e5 to
5a58cf0
Compare
|
Thanks for this. I tested the board and it works (but I programmed using USB DFU instead, with a modified config). Merged in 1f52a6f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the most readily available NRF52840 board I could find for BLE testing.
A few of other minor fixes for the NRF port included:
make deploytarget (consistent with other ports)