travis: Add job to build and test unix minimal port. #5227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. Is it worth making minimal configs for other ports to ensure they aren't depending on something that should be an optional feature? |
That's a lot of work, and since other (bare-metal) ports don't have automated tests running in Travis CI, I don't see how it's that useful. Running unix-minimal should be enough to check that the test suite can be run against almost any build, regardless of its config options. |
|
Looks like this will require a lot of work to update the tests, to get unix-minimal to pass the tests... |
And requires uintptr_t to declare the default version in py/mphal.h.
Only use % formatting when testing % itself, because only str.format is guaranteed to be available on any port.
Because "version" will always be there, but "exit" may not.
So they can be automatically skipped if bytearray is not enabled.
Using bytes will test the same path for the buffer protocol in py/objtype.c.
So they can be automatically skipped if slice is not enabled.
To test that unix minimal port builds, and that test-suite can run with minimal features enabled.
7864283 to
162016a
Compare
|
All tests fixed, and merged. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 26, 2021
esp32s2: rework nvm/nvs storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test that test-suite can run with minimal features enabled.