extmod/modbluetooth: Rename to "ubluetooth" #5247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgeorge
reviewed
Oct 22, 2019
ports/esp32/mpconfigport.h
Outdated
| extern const struct _mp_obj_module_t mp_module_onewire; | ||
|
|
||
| #if MICROPY_PY_BLUETOOTH | ||
| #define BLUETOOTH_BUILTIN_MODULE { MP_ROM_QSTR(MP_QSTR_bluetooth), MP_ROM_PTR(&mp_module_bluetooth) }, | ||
| #define BLUETOOTH_BUILTIN_MODULE { MP_ROM_QSTR(MP_QSTR_ubluetooth), MP_ROM_PTR(&mp_module_ubluetooth) }, | ||
| #else | ||
| #define BLUETOOTH_BUILTIN_MODULE | ||
| #endif |
There was a problem hiding this comment.
Maybe this stuff should be moved to py/objmodule.c, next to all the other extmod modules that are included if their config value is enabled?
For consistency with "umachine". Now that weak links are enabled by default for built-in modules, this should be a no-op, but allows extension of the bluetooth module by user code. Also move registration of ubluetooth to objmodule rather than port-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4370 (equivalent change for array->uarray), and #5241 (weak links by default).
This should be a no-op for most users, but allows customisation.