py/runtime: Reorder some binary ops so they don't require conditionals. #5273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runtime0.h is part of the MicroPython ABI so it's simpler if it's independent of config options, like MICROPY_PY_REVERSE_SPECIAL_METHODS. This commit has no effect when MICROPY_PY_REVERSE_SPECIAL_METHODS is disabled. With this option enabled it reduces code size by about 60 bytes.
|
Merged in 323d478 |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 31, 2021
Fix nrf light_sleep when on usb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtime0.his part of the MicroPython ABI (see #5083) so it's simpler if it's independent of config options, likeMICROPY_PY_REVERSE_SPECIAL_METHODS.What's effectively done here is just move
MP_BINARY_OP_DIVMODandMP_BINARY_OP_CONTAINSup in the enum, then remove the#if MICROPY_PY_REVERSE_SPECIAL_METHODSconditional.Without this change .mpy files would need to have a feature flag for
MICROPY_PY_REVERSE_SPECIAL_METHODS(when using #5083).This commit has no effect when
MICROPY_PY_REVERSE_SPECIAL_METHODSis disabled. With this option enabled it reduces code size by about 60 bytes.