esp32: Remove "esponewire.c" in favor of extmod/modonewire #5289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed this file is unused, thanks! Merged in d209f9e |
kamtom480
pushed a commit
to kamtom480/micropython
that referenced
this pull request
Sep 3, 2021
…S2_Stage_Support Added STAGE support for my TinyS2 board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear George and the MicroPython community,
while working on [1,2], we found that the file
ports/esp32/esponewire.cmight have slipped in accidentally from the esp8266 port. As far as we can see, the respective functionality is completely covered by the platform-agnosticmodonewireright now.Please correct us if we are wrong on that, otherwise feel free to merge this humble adjustment which confused me a bit firsthand when researching into that topic.
With kind regards,
Andreas.
[1] https://community.hiveeyes.org/t/untersuchung-und-verbesserung-des-timings-bei-der-ansteuerung-der-ds18b20-sensoren-unter-micropython/2309
[2] pycom/pycom-micropython-sigfox#356