tests/run-tests: Skip extmod/ticks_diff and extmod/time_ms_us automatically. #5617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d493009 to
9bdcdbe
Compare
|
Good change, thanks. Merged in 0852acf |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Nov 30, 2021
Shrink 3 SAMD builds by disabling onewireio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better decided this way, in runtime code, instead of hard-coding it in the tests execution framework.
It also means that if, at any point in the future, the missing functions will be implemented - the tests will "activate" automatically for the port.
Taken from #5482 (where I depend on this auto skipping).