Skip to content

Split ESP32 ESP-IDF v3 and v4 travis builds #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tve
Copy link
Contributor

@tve tve commented Mar 3, 2020

I'm trying to split the esp-idf v3 and v4 travis jobs to make it easier to see what is happening when there is a failure. The majority of the time is taken by the actual make process so the extra overhead of the double download seems minimal (and it's at travis' expense anyway).

@tve
Copy link
Contributor Author

tve commented Apr 9, 2020

Looks like it now takes 3min for each of the esp-idf v3/v4 runs, vs. somewhat over 4min before. Not a huge time gain when run in parallel but makes it easier to find the problem when there is one.

@tve
Copy link
Contributor Author

tve commented Apr 10, 2020

I forgot to mention that this PR also fixes the fact that the esp32 w/esp-idf-v4 firmware is being built with the wrong GCC 5.2.0 instead of the correct GCC 8.2.0.
Oh, and travis failed on the ARM bare minimal port due to a 4 bytes code size increase, which must be due to gremlins...

.travis.yml Outdated
- stage: test
env: NAME="esp32 port build"
env: NAME="esp32 ESP-IDFv3 port build"
install:
- sudo apt-get install python3-pip
- sudo pip3 install 'pyparsing<2.4'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pyparsing is only needed for IDFv4, so both these pip lines can go.

@dpgeorge
Copy link
Member

I forgot to mention that this PR also fixes the fact that the esp32 w/esp-idf-v4 firmware is being built with the wrong GCC 5.2.0 instead of the correct GCC 8.2.0.

Ok, that's a good fix.

@dpgeorge
Copy link
Member

Ahh, pyparsing is needed for IDF v3, it's just that it can be the latest version.

I've merged this in e880c8d without the commit that removes pyparsing for IDF v3.

@dpgeorge dpgeorge closed this Apr 13, 2020
@tve tve deleted the patch-1 branch April 13, 2020 06:12
tannewt added a commit to tannewt/circuitpython that referenced this pull request Dec 29, 2021
Fix website action dependencies; don't build everything on CI changes - 7.1.x backport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants