Skip to content

tests/multi_net: Add key/cert to SSL test so it works on mbedTLS. #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tests/multi_net: Add key/cert to SSL test so it works on mbedTLS. #5944

wants to merge 1 commit into from

Conversation

dpgeorge
Copy link
Member

This test now works on unix/unix, unix/PYBD, PYBD/PYBD.

@dpgeorge dpgeorge added the tests Relates to tests/ directory in source label Apr 19, 2020
@tve
Copy link
Contributor

tve commented Apr 19, 2020

I already fixed this in https://github.com/micropython/micropython/pull/5840/files#diff-ba11c1e2aa03fc38fcfc7d703668c1f3 with the bonus that it also works with CPython.

@dpgeorge
Copy link
Member Author

dpgeorge commented May 2, 2020

Oh, thanks, I missed that.

I'll leave this open until the other PR with the fix is merged.

@dpgeorge
Copy link
Member Author

dpgeorge commented Feb 3, 2022

I totally forgot about this PR and redid this patch in 2c9dc57

The approach in #5840 is still better because it works with CPython, so need to get to that at some point.

@dpgeorge dpgeorge closed this Feb 3, 2022
@dpgeorge dpgeorge deleted the tests-multi-net-ssl-keycert branch February 3, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests Relates to tests/ directory in source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpgeorge @tve