Skip to content

extmod/vfs_lfsx.c: fix path handling in uos.stat() for lfs #5986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

robert-hh
Copy link
Contributor

This fixes the bug, that stat(filename) would not consider the
actual directory. So if e.g. the cwd is "lib", then stat("main.py")
would return the info for "/main.py" instead of "/lib/main.py". And
vice versa it would not return the info for a file in that directory,
if just the filename was give.

But still, path names with . or .. will fail. That fix will come
separately.

This fixes the bug, that stat(filename) would not consider the
actual directory. So if e.g. the cwd is "lib", then stat("main.py")
would return the info for "/main.py" instead of "/lib/main.py". And
vice versa it would not return the info for a file in that directory,
if just the filename was give.

But still, path names with . or .. will fail. That fix will come
separately.
@robert-hh
Copy link
Contributor Author

The usual trouble with git. Da capo.

@robert-hh robert-hh closed this Apr 29, 2020
@robert-hh robert-hh deleted the lfs_stat branch April 29, 2020 16:15
@tve
Copy link
Contributor

tve commented Apr 29, 2020

I see that you opened a fresh PR, but in the future, try git add -pi and step through each hunk. It's really helpful as a general way of operating 'cause often there's also left-over debug code that one wants to leave out from commits/PRs (at least that happens to me).

tannewt added a commit to tannewt/circuitpython that referenced this pull request Mar 8, 2022
This allows you to list and explore connected USB devices. It
only stubs out the methods to communicate to endpoints. That will
come in a follow up once TinyUSB has it. (It's in progress.)

Related to micropython#5986
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jul 7, 2023
Connects up read, write and ctrl_transfer to TinyUSB. USB Host
support is available on iMX RT and RP2040.

Fixes micropython#6527 (imx) and fixes micropython#5986 (rp2).
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jul 10, 2023
Connects up read, write and ctrl_transfer to TinyUSB. USB Host
support is available on iMX RT and RP2040.

Fixes micropython#6527 (imx) and fixes micropython#5986 (rp2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants