Two small changes #655
Merged
Two small changes #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once a double quote has been found, the subsequent discovery of a single quote won't change behaviour at all, so don't bother looking for one.
|
Thanks! A simple change, but reduced ARM Thumb code size by 24 bytes. |
|
It's fun when a 24 byte accomplishment is considered something :) |
|
Please, go ahead and submit as many PRs as you can for changes that have equivalent functionality, but use less bytes! |
|
Haha. I was mainly looking to see if PEP 393 support would be hard to add, because that's something I believe very strongly in. These were completely incidental. |
|
@pfalcon might have opinions on PEP 393 http://legacy.python.org/dev/peps/pep-0393/. |
|
Opened a new issue #657 to discuss PEP 393 / Unicode. |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 13, 2018
Having the `active_read = false` in the background function left a chance that a new_write occurs before active_read is set to false. In that case, we'll read the appropriate data rather than write it and never clear the active write. Hopefully fixes micropython#655.
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Mar 14, 2018
Waiting to do so risks accidentally queueing another response. Hopefully fixes micropython#655 but we'll let @jerryneedell confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two trivial edits, just stuff I noticed as I was poking around.