-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
esp32: remove unix socket error munging #6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
This isn't really working yet... I'm trying to understand what's happening, I'm not sure esp-idf 4.1 fixed this in the end... |
I'm finding it difficult to get to the bottom of this... Looks to me like the xtensa tools used by esp-idf 4.1 still define EINPROGRESS=119. THat makes it incompatible with MP's definition of 115. As far as I can tell (it's hard to figure out where the errno.h include really comes from) the source is Assuming I'm correct, should we go back to #5968? |
I did some more sleuthing... I see linux defining EINPROGRESS as 115 and other stuff, such as LwIP as 119. I don't know where this discrepancy comes from, but as far as I can tell, it's there. MP's uerrno says it's 115. LwIP and xtensa-esp32's newlib say it's 119. One option is for uerrno to get the value from the C header file and end up with 119 on the esp32 and 115 elsewhere. The other option is to enforce the 115. In the latter case, one option is to do it for LwIP like I did in #5968 and another is to do a translation everywhere. My head is spinning, I don't know which is 'best' and don't really care anymore. All I know is that it needs to be fixed one way or the other... |
I had a look myself and it seems that So, how about just changing
+1 I'll work on that in #6473 as soon as I can. |
Please see branch |
superseded by #6613 |
Upgrade the pewpew-lcd frozen library to tag 1.0.1
This builds on #6473 and replaces #5968.
It would be really helpful to (a) get a branch going with the cmake stuff so it's easier to make PRs against that, and (b) put a stake in the ground for what should be supported going forward and what not WRT older versions of esp-idf.
If you stick to your goals for v1.14 (efficient polling with "uevent", and external events in uasyncio; non-blocking SSL support in uasyncio) I propose to support esp-idf v4.1 and up only, ditch support for v3.x and v4.0. It has to happen at some point and I think it's quite some extra work to put all the #ifdef in , test them, and eventually remove them. Users that want esp-idf v3 can stick to MP v1.13: it works great.