Skip to content

NRF: Add support for using frozen manifest in the nrf port. #6755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

iabdalkader
Copy link
Contributor

FROZEN_MPY_DIR is still supported, modules can be added to boards/manifest.py or with make FROZEN_MPY_DIR=freeze

@glennrub
Copy link
Contributor

glennrub commented Jan 6, 2021

Thanks @iabdalkader.

I guess this is quite close to the #5379 which i have not pushed forward, as it will be superseded by #5472 (with similar commit).

@dpgeorge made an a comment on the first PR of mine that it would be nice to have this tested in the build system. I agree, and I did not want to waste default memory on freezing something random just for a build test. Hence, I have moved this to #5472 which actually needs something frozen (and also build tested).

@iabdalkader
Copy link
Contributor Author

So this is not needed ?

BTW you should remove this from nrf/Makefile it's already done again in py/mkrules.mk, and manifest is going to be used anyway:

ifneq ($(FROZEN_MPY_DIR),)
FROZEN_MPY_PY_FILES := $(shell find -L $(FROZEN_MPY_DIR) -type f -name '*.py')
FROZEN_MPY_MPY_FILES := $(addprefix $(BUILD)/,$(FROZEN_MPY_PY_FILES:.py=.mpy))
endif

py/mkrules.mk

ifneq ($(FROZEN_MPY_DIR),)
$(info Warning: FROZEN_MPY_DIR is deprecated in favour of FROZEN_MANIFEST)
# make a list of all the .py files that need compiling and freezing
FROZEN_MPY_PY_FILES := $(shell find -L $(FROZEN_MPY_DIR) -type f -name '*.py' | $(SED) -e 's=^$(FROZEN_MPY_DIR)/==')
FROZEN_MPY_MPY_FILES := $(addprefix $(BUILD)/frozen_mpy/,$(FROZEN_MPY_PY_FILES:.py=.mpy))

@iabdalkader
Copy link
Contributor Author

@dpgeorge @glennrub

Hi, why does this PR fail ? seems there's issue with the nrf port build:

mpy-cross not found at /home/runner/work/micropython/micropython/mpy-cross/mpy-cross, please build it first
make: *** [../../py/mkrules.mk:142: build-pca10040/frozen_content.c] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory '/home/runner/work/micropython/micropython/ports/nrf'
Error: Process completed with exit code 2.

Also it's been more than 6 month and #5472 is still not merged yet, and no frozen manifest either. Can you please consider merging this which would unblock frozen manifests until 5472 is rebased and merged ? It should even make it so there's slightly less to review in 5472.

@iabdalkader iabdalkader deleted the nrf_manifest branch July 17, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants