esp32: make machine.soft_reset() work in main.py #6782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, a good addition. Don't worry about a test. |
|
Rebased, tested against new cmake build, and merged in d28dbcd |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 19, 2022
…ries-8.0.0-beta.0a update frozen HID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes two issues on the esp32: it enables
machine.soft_reset()to be called inmain.pyand it enablesmachine.reset_cause()to correctly identify a soft reset. The former is useful in that it enables soft resets in applications that are started at boot time.The support is patterned after the stm32 port.
No docs changes 'cause this makes things works as documented.
No unit test, I can create one but due to the reset it ends up being pretty messy.