Skip to content

tests: rename run-tests to run-tests.py and format with black, for consistency #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

dpgeorge
Copy link
Member

All other test runner scripts (and scripts in general, eg in tools/) that are written in Python end in .py, so rename run-tests to run-tests.py.

Doing this rename then makes it fall under the automatic code formatting with Black (IMO an additional good reason to rename it), so it's also reformatted to conform to Black formatting.

@dpgeorge dpgeorge added the tests Relates to tests/ directory in source label Mar 11, 2021
@dpgeorge
Copy link
Member Author

@stinos @jimmo any objections (or better ideas)?

Was inspired by #6909 to make that diff smaller.

@jimmo
Copy link
Member

jimmo commented Mar 11, 2021

I nearly did this in #6909 anyway. +1 from me.

@stinos
Copy link
Contributor

stinos commented Mar 11, 2021

Yes +1 both on renaming and formatting.

Perhaps adding a .git-blame-ignore-revs file like described here https://github.com/psf/black#migrating-your-code-style-without-ruining-git-blame is also interesting? Both for this commit and the ones where formatting was introduced.

@dpgeorge
Copy link
Member Author

Perhaps adding a .git-blame-ignore-revs file like described here

Hmm, yes, looks interesting.

Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tests-rename-run-tests-py branch from 58f97b2 to 2a38d71 Compare March 12, 2021 08:56
@dpgeorge dpgeorge merged commit 2a38d71 into micropython:master Mar 12, 2021
@dpgeorge dpgeorge deleted the tests-rename-run-tests-py branch March 12, 2021 09:08
Wind-stormger pushed a commit to BPI-STEAM/micropython that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Relates to tests/ directory in source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants