Is it worth moving dotstar.py to /drivers or /extmod so other boards can share it (and include via manifest.py)?

Is it worth moving dotstar.py to /drivers or /extmod so other boards can share it (and include via manifest.py)?

The last discussion I had with @dpgeorge about this (a loooooong time ago just as TinyPICO was launching) was that it should probably be move to wherever the other modules live, but that it needed to be made to look more "micropython like" - and I never really got there.

What would be required to make dotstar more micropython like? Removing the setters and properties?

What would be required to make dotstar more micropython like? Removing the setters and properties?

I honestly cant remember what the conversation entailed, but yeah, I think the properties were some of it. It was a long time ago. It's a small script, so I am sure it will take @dpgeorge < 2min to make it how he wants it to be.

What would be required to make dotstar more micropython like? Removing the setters and properties?

I honestly cant remember what the conversation entailed, but yeah, I think the properties were some of it. It was a long time ago. It's a small script, so I am sure it will take @dpgeorge < 2min to make it how he wants it to be.

I guess you don't want to break backwards compatibility anymore, so that makes it harder to change...

Anyway, since this dotstar.py file is moving/renaming I suggest it get moved to drivers/led/dotstar.py as-is. And then in the future someone can make it more portable/generic so it runs on other boards.

@dpgeorge I fixed all of those things... some of them (like the machine_pins.c was because I had some C3 stuff in there than I removed, but not cleanly, sorry.
Cheers :)

It would be good to have the additions of UM_TINYS2 and UM_FEATHERS2 as separate commits. I can do this during merge, but it would be easier if you could do it @UnexpectedMaker :)

It would be good to have the additions of UM_TINYS2 and UM_FEATHERS2 as separate commits. I can do this during merge, but it would be easier if you could do it @UnexpectedMaker :)

I have no idea how Id do that. Remove the folders from my local repo, re-commit? Then re-add them after the PR is merged?

I have no idea how Id do that.

Something like this (in ports/esp32/ dir):

git reset HEAD^^^
git add boards/sdkconfig.spiram_sx partitions-16MiB.csv
git commit -a
(make commit for s2/s3 support)
git add boards/UM_TINYS2/
git commit
(make commit for um-tinys2)
git add boards/UM_FEATHERS2/
git commit
(make commit for um-feathers2)
git push --force

I have no idea how Id do that.

Something like this (in ports/esp32/ dir):

git reset HEAD^^^
git add boards/sdkconfig.spiram_sx partitions-16MiB.csv
git commit -a
(make commit for s2/s3 support)
git add boards/UM_TINYS2/
git commit
(make commit for um-tinys2)
git add boards/UM_FEATHERS2/
git commit
(make commit for um-feathers2)
git push --force

Won't that reset ALL of my changes in the PR if I reset to HEAD? My git fu is not strong.

Won't that reset ALL of my changes in the PR if I reset to HEAD? My git fu is not strong.

Yes it'll reset the 3 most recent commits.

You can do it on a new branch:

git checkout -b "s2s3-support"

then run the commands above

See #7222 for a version of this with reworked commits.