Skip to content

update tinyusb and pico-sdk submodules, and get rp2 compiling with gcc11 #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

dpgeorge
Copy link
Member

This PR:

  • updates tinyusb submodule to 0.10.1
  • updates pico-sdk submodule to 1.2.0 (requires the newer tinyusb)
  • suppresses some gcc warnings in rp2 so it complies with gcc11

New tinyusb was tested on rp2 Pico and Teensy 4.0. Needs testing on other boards.

@codecov-commenter
Copy link

Codecov Report

Merging #7474 (cf3d2cf) into master (4ada56d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7474      +/-   ##
==========================================
- Coverage   98.28%   98.28%   -0.01%     
==========================================
  Files         154      154              
  Lines       19985    19985              
==========================================
- Hits        19643    19642       -1     
- Misses        342      343       +1     
Impacted Files Coverage Δ
py/parse.c 99.79% <0.00%> (-0.21%) ⬇️
py/obj.c 96.82% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ada56d...cf3d2cf. Read the comment docs.

Comment on lines +191 to +196
set_source_files_properties(
${PICO_SDK_PATH}/src/rp2_common/pico_double/double_math.c
${PICO_SDK_PATH}/src/rp2_common/pico_float/float_math.c
PROPERTIES
COMPILE_OPTIONS "-Wno-error=uninitialized"
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably related to raspberrypi/pico-sdk#501 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's the same problem (I use Arch Linux as well)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will just be a work-around for now, to hopefully be removed in the future

@dpgeorge
Copy link
Member Author

dpgeorge commented Jul 5, 2021

Tested on nrf pca10059 board (which uses tinyusb) and it works.

dpgeorge added 3 commits July 5, 2021 16:18
Signed-off-by: Damien George <damien@micropython.org>
Signed-off-by: Damien George <damien@micropython.org>
These warnings appear with GCC 11.  Keep them as warnings but not as
compiler errors so they can be dealt with properly in the future.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the update-tinyusb-pico-sdk branch from cf3d2cf to 031fe0f Compare July 5, 2021 06:18
@dpgeorge dpgeorge merged commit 031fe0f into micropython:master Jul 5, 2021
@dpgeorge dpgeorge deleted the update-tinyusb-pico-sdk branch July 5, 2021 06:43
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants