Factor out efficient mp_hal_stdout_tx_strn_cooked from ports to lib/utils/stdout_helpers.c #7491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7491 +/- ##
==========================================
- Coverage 98.29% 98.27% -0.02%
==========================================
Files 154 154
Lines 19990 19988 -2
==========================================
- Hits 19649 19644 -5
- Misses 341 344 +3
Continue to review full report at Codecov.
|
To reduce the number of calls to mp_hal_stdout_tx_strn and improve the overall throughput of printing data. This implementation is taken from ports/stm32/mphalport.c. Signed-off-by: Damien George <damien@micropython.org>
To reduce code duplication. Signed-off-by: Damien George <damien@micropython.org>
93ab078 to
132d938
Compare
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Jan 28, 2023
…ries-2023-01-26 update frozen libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This efficient implementation of
mp_hal_stdout_tx_strn_cookedis repeated by a few ports (esp32, esp8266, cc3200, stm32) and needed by others (eg rp2), so just make the common version inlib/utils/stdout_helpers.cthis efficient one so all ports use the same one.This helps with #7479, to make
print(data)faster on rp2.