Skip to content

mimxrt: Initial documentation for the mimxrt port. #7494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

robert-hh
Copy link
Contributor

While the mimxrt port is made as compatible as possible to the mainline of ports, some aspects are slightly different. These documentation pages address some of them. If consists mainly of a quickref, the introduction and the 'general' pages. More to follow.
Note: I2C is already mentioned, even if it not yet merged. And SDCard as well, which is in good shape and under test and refinement now.

@robert-hh robert-hh force-pushed the mimxrt_docs branch 2 times, most recently from 98f45ff to bd0a296 Compare July 12, 2021 19:49
@robert-hh robert-hh force-pushed the mimxrt_docs branch 9 times, most recently from cf84ec4 to e2d42be Compare August 4, 2021 19:27
@dpgeorge
Copy link
Member

dpgeorge commented Aug 5, 2021

Is this ready for final review, or do you want to wait until other features are implemented?


Note
Most of the controllers do not have internal flash memory. Therefore
their flash capacity is dependent on an external flash chip!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I suggest that exclamation marks are not used in documentation unless really warranted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Will be changed.

@robert-hh
Copy link
Contributor Author

Is this ready for final review, or do you want to wait until other features are implemented?

That is definitely an interim state, but I made it to show the Pin assignments of Devices like UART, SPI, I2C and PWM to pins. These are documented for Teensy, but not for the MIMXRT EVK boards. It contains some documentation about features in progress to get publish, like SDCard and PWM, and also the tiny DHT support addition which I have ready but did not send a PR yet. I'm preparing another "various" PR for collected small additions.
So yes, publishing it is helpful, but there will be updates and extensions, if new features are added, like CAN, I2S, Watchdog, extended Flash, ... The devices has still quite a few options to offer.

@robert-hh robert-hh force-pushed the mimxrt_docs branch 2 times, most recently from b6ece64 to 6b03dba Compare August 13, 2021 15:08
@robert-hh robert-hh force-pushed the mimxrt_docs branch 5 times, most recently from 813d446 to 97e2d46 Compare September 30, 2021 14:28
@robert-hh robert-hh force-pushed the mimxrt_docs branch 4 times, most recently from 59e04ef to 26ea6cb Compare October 14, 2021 12:33
robert-hh added a commit to robert-hh/micropython that referenced this pull request Oct 25, 2021
The ARCH MIX board exposes the Ethernet Pins at it's connectors.
Therefore the software is configured for using a LAN8720 PHY device.
Breakout boards with the LAN8720 are available widespread for a low
price. The documentation about Pin/GPIO assignment and firmare upload
can be found in PR micropython#7494.
@dpgeorge
Copy link
Member

In this PR there are machine.PWMmimxrt.rst and network.LANmimxrt.rst files. This does not look right, the API for PWM and LAN should match other ports and so the mimxrt should just use machine.PWM.rst and network.LAN.rst. Additional information about PWM/LAN specific to the mimxrt port should go in the following locations (depending on which makes more sense):

  1. existing machine.PWM.rst/network.LAN.rst docs in mimxrt-specific sections
  2. mimxrt quickref
  3. mimxrt tutorial

@robert-hh
Copy link
Contributor Author

robert-hh commented Mar 30, 2022

Thank you for all the review work. You cleaned up many PRs and notes piling up since long. I recall some like the one about the "low hanging fruits", which seemed out of reach for me when reading it the first time.
I'll work on the suggested changes.

@robert-hh
Copy link
Contributor Author

@dpgeorge About moving network.LANmimxrt.rst file: There is no network.LAN,rst file. There is a network.rst file, describing an abstract class, and a set of specific files for CC3, WIZNET5K, WLAN, WLANWiPy. The LANmimxrt.rst file follows that structure.

Since it contains all the pin assignment tables, it fits better there.
@dpgeorge
Copy link
Member

About moving network.LANmimxrt.rst file: There is no network.LAN,rst file

OK, then this network.LANmimxrt.rst file can be renamed to network.LAN.rst and form the basis of the docs for that class.

Editorial change: Move the MIMXRT specific sentence to the end of
the section.
@robert-hh
Copy link
Contributor Author

Done & updated in the repository.

@dpgeorge
Copy link
Member

dpgeorge commented Apr 4, 2022

Squashed and merged in 7a447e0, with minor changes:

  • removed unused block diagram image
  • reduced size of teensy 4.1 image
  • fixed download link
  • fixed typos
  • fixed and adjusted formatting

One thing I would say is that the quickref is too long. I think the tables of pins (eg for PWM) could go elsewhere, eg in a specific file with pinouts for each board. But that's not a critical thing.

Anyway, this is a good addition, thank you!

@dpgeorge dpgeorge closed this Apr 4, 2022
@robert-hh
Copy link
Contributor Author

Thank you very much for merging. I'll split the quickref up with the next change.

@robert-hh robert-hh deleted the mimxrt_docs branch April 4, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants