Skip to content

WIP: Get bluetooth services handles #7754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarceauFillon
Copy link

No description provided.

@jimmo
Copy link
Member

jimmo commented Sep 10, 2021

If I was doing modbluetooth again from scratch, I would have included the service handles in the tuple returned from gatts_register_services, but at the time nothing was using them. (This would be easy to support on btstack too).

See #7675 (comment) -- because this is only to support the database hash functionality, I'd much rather see this supported by the built-in default GATT service, rather than putting the onus on the Python code.

I think it looks like we're already going to have to fork NimBLE for other reasons (e.g. not using a hardcoded IRK, adding support for doing private addressing on older controllers, and some issues around the changes in v1.4), so I guess this would be a good first thing to add to our fork. I notice Espressif have already done the same.

@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Oct 15, 2021
@dpgeorge
Copy link
Member

because this is only to support the database hash functionality, I'd much rather see this supported by the built-in default GATT service, rather than putting the onus on the Python code.

This (database hash functionality) is done in C in PR #7877. So this PR is no longer needed and can be closed.

@dpgeorge dpgeorge closed this Aug 12, 2022
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants