Skip to content

extmod/modbluetooth: Add gap_unpair command. #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewleech
Copy link
Contributor

@andrewleech andrewleech commented Sep 23, 2021

This function deletes the pairing details from the DB on both the application and the radio, so can be used to free up IRK slots on the radio.

Note: this only works on nimble as pairing/bonding has not been fully implemented on other stacks.

Background

In my application, we have a stm327f765 chip running micropython, with a build of the official nimble uart/hci application running on a separate nrf52810 (https://github.com/apache/mynewt-nimble/tree/master/apps/blehci)

We use this with aioble and paring/bonding.

It's been found that this nimble hci radio only has buffer/storage for 4 RPA / IRK addressing lookups, so if you've got more devices than this stored in the pairing/bonding database, any new devices that come along and try to pair/bond seem to work initially, but upon disconnect/reconnect the pairing details are lost.
Also, if you've got more devices than this stored in the bond database, with the current inplementation of aioble the fact these are stored in a dict/json file means the order is not strictly controlled, so you can't know for certain which devices keys will be loaded first/last into the radio - which ever ones don't fit can fail to connect correctly.

As part of work to provide some control over this issue by allowing an application to limit the number of devices bonded, this gap_unpair() function is needed to remove keys from the ble stack / radio.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #7845 (6aa0479) into master (30b6ce8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7845   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         153      153           
  Lines       20145    20145           
=======================================
  Hits        19838    19838           
  Misses        307      307           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b6ce8...6aa0479. Read the comment docs.

@andrewleech andrewleech force-pushed the unpair branch 2 times, most recently from de857fc to ae8b7f9 Compare September 27, 2021 07:57
@andrewleech andrewleech changed the title Draft: extmod/modbluetooth: Add gap_unpair command. extmod/modbluetooth: Add gap_unpair command. Sep 28, 2021
@dpgeorge dpgeorge added the extmod Relates to extmod/ directory in source label Oct 15, 2021
This function deletes the pairing details from the DB on both
the application and the radio, so can be used to free up IRK
slots on the radio.
RetiredWizard pushed a commit to RetiredWizard/micropython that referenced this pull request Apr 16, 2023
@projectgus
Copy link
Contributor

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extmod Relates to extmod/ directory in source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants